Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove repetitive and unnecessary judgment #7869

Merged
merged 3 commits into from
May 28, 2021

Conversation

BurningCN
Copy link
Member

@BurningCN BurningCN commented May 26, 2021

What is the purpose of the change

The metadataService.getExportedURLs() method will be called in the selectMetadataServiceExportedURL method. This method has already made this judgment, so the repeated judgments here can be removed

image

image

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2021

Codecov Report

Merging #7869 (cead7fb) into master (e845e16) will increase coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7869      +/-   ##
============================================
+ Coverage     59.28%   59.55%   +0.27%     
- Complexity      529      555      +26     
============================================
  Files          1077     1088      +11     
  Lines         43565    43851     +286     
  Branches       6368     6399      +31     
============================================
+ Hits          25826    26115     +289     
+ Misses        14879    14833      -46     
- Partials       2860     2903      +43     
Impacted Files Coverage Δ
.../apache/dubbo/config/bootstrap/DubboBootstrap.java 43.83% <ø> (+0.13%) ⬆️
...ient/metadata/ProtocolPortsMetadataCustomizer.java 0.00% <ø> (ø)
.../dubbo/remoting/transport/MultiMessageHandler.java 80.00% <0.00%> (-20.00%) ⬇️
...bo/rpc/cluster/support/FailbackClusterInvoker.java 52.45% <0.00%> (-18.04%) ⬇️
...o/remoting/transport/ChannelHandlerDispatcher.java 60.00% <0.00%> (-10.00%) ⬇️
...ting/exchange/support/header/HeartbeatHandler.java 83.72% <0.00%> (-9.31%) ⬇️
...va/org/apache/dubbo/rpc/support/ProtocolUtils.java 61.53% <0.00%> (-8.03%) ⬇️
...apache/dubbo/rpc/protocol/injvm/InjvmProtocol.java 72.22% <0.00%> (-5.56%) ⬇️
.../threadpool/manager/DefaultExecutorRepository.java 80.95% <0.00%> (-4.54%) ⬇️
.../rpc/protocol/dubbo/LazyConnectExchangeClient.java 49.45% <0.00%> (-4.40%) ⬇️
... and 100 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e845e16...cead7fb. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 6bca92b into apache:master May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants