Remove the forced conversion in the ServiceInstanceMetadataCustomizer#customize method #7870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#customize method
BurningCN
commented
May 26, 2021
...c/main/java/org/apache/dubbo/registry/client/metadata/ServiceInstanceMetadataCustomizer.java
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7870 +/- ##
============================================
+ Coverage 59.28% 59.55% +0.27%
- Complexity 529 557 +28
============================================
Files 1077 1088 +11
Lines 43565 43853 +288
Branches 6368 6400 +32
============================================
+ Hits 25826 26116 +290
+ Misses 14879 14839 -40
- Partials 2860 2898 +38 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Remove the forced conversion in the ServiceInstanceMetadataCustomizer#customize method