Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formatting code #8048

Merged
merged 1 commit into from
Jun 16, 2021
Merged

formatting code #8048

merged 1 commit into from
Jun 16, 2021

Conversation

m1ngyuan
Copy link
Contributor

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2021

Codecov Report

Attention: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.82%. Comparing base (f7cfe6e) to head (fa97093).
Report is 994 commits behind head on 3.0.

Files with missing lines Patch % Lines
...egistry/kubernetes/util/KubernetesConfigUtils.java 96.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.0    #8048      +/-   ##
============================================
- Coverage     60.85%   60.82%   -0.04%     
+ Complexity      313      312       -1     
============================================
  Files          1070     1070              
  Lines         44859    44832      -27     
  Branches       6699     6699              
============================================
- Hits          27299    27267      -32     
- Misses        14551    14555       +4     
- Partials       3009     3010       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CrazyHZM CrazyHZM merged commit bf5e72e into apache:3.0 Jun 16, 2021
@m1ngyuan m1ngyuan deleted the formatting_code branch June 16, 2021 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants