Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add codecov component #992 #993

Merged
merged 4 commits into from
Dec 29, 2017
Merged

add codecov component #992 #993

merged 4 commits into from
Dec 29, 2017

Conversation

lovepoem
Copy link
Member

@lovepoem lovepoem commented Dec 5, 2017

What is the purpose of the change

#992

Brief changelog

update pom.xml
.travis.yml

we can get:
the test coverage rate of the entire project
coverage rate change of every PR

@chickenlj
Copy link
Contributor

Hello, lovepoem. Have u test this in your own repository?

@lovepoem
Copy link
Member Author

lovepoem commented Dec 8, 2017

Yes. https://github.com/lovepoem/codecov-travis-maven-test is a new repository I created for this issue three days ago .

Please see the examples:
https://github.com/lovepoem/codecov-travis-maven-test
lovepoem/codecov-travis-maven-junit4-example#3

dubbo code master should do with github account:
login https://travis-ci.org/ and add dubbo repository to https://travis-ci.org/ (it seems done)
login https://codecov.io/ and add dubbo repository to https://codecov.io/

@codecov-io
Copy link

codecov-io commented Dec 11, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@da0f63e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #993   +/-   ##
=========================================
  Coverage          ?   27.53%           
=========================================
  Files             ?      789           
  Lines             ?    41577           
  Branches          ?     8476           
=========================================
  Hits              ?    11449           
  Misses            ?    28079           
  Partials          ?     2049

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da0f63e...245e63b. Read the comment docs.

@chickenlj
Copy link
Contributor

Is CodeCov necessary? I find many other github projects haven't integrate with CodeCov.
Will it help us to figure out whether a PR has enough UT?

@lovepoem
Copy link
Member Author

I think a rich test case is necessary for the quality of the code. Travis Ci and codecov were only popular in the last two years. Codecov does help us check every PR test code and improve the test code coverage.

@lovepoem lovepoem merged commit 72cecba into apache:master Dec 29, 2017
@lovepoem lovepoem deleted the add_codecov branch December 30, 2017 02:07
casnanda added a commit to casnanda/dubbo that referenced this pull request Jan 14, 2018
* 'master' of https://github.com/alibaba/dubbo: (248 commits)
  获取Serializer和Deserializer时,高并发情况下线程block (apache#1196)
  Merge pull request from apache#1170, fix typo of SUFFIXES.
  apache#992 add codecov component (apache#993)
  Merge pull request from apache#1131,  delete empty comments.
  Translate missing content and add apache license
  Add apache license and remove @author comment
  I18N effort for dubbo-common, translate the missing content
  I18N effort for code base, translate the missing content
  I18N effort for dubbo-admin, translate the missing content
  I18N effort for dubbo-cluster, translate the missing content
  I18N effort, translate the missing content
  I18N effort for dubbo-remoting, translate the missing content
  Change default locale from zh to en
  I18N effort for dubbo-admin, xml and UT, apache#1124
  I18N effort for dubbo-admin, apache#1124
  fix typo
  translate comments into english
  translate comments
  fix typo
  change comment to english
  ...

# Conflicts:
#	dubbo-cluster/src/main/java/com/alibaba/dubbo/rpc/cluster/loadbalance/RoundRobinLoadBalance.java
#	dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ServiceConfig.java
rolandhe pushed a commit to rolandhe/dubbo that referenced this pull request Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants