Merge pull request #19514 from apache/fix/graph-dispose

fix(graph): fix force layout iteration timer doesn't stop after disposing the chart
apache · Jan 16, 2024 · 6cae00c · 6cae00c
2 parents 94dd855 + 690ebe6
commit 6cae00c
Show file tree

Hide file tree

Showing 4 changed files with 65 additions and 4 deletions.
diff --git a/src/chart/graph/GraphView.ts b/src/chart/graph/GraphView.ts
@@ -208,6 +208,8 @@ class GraphView extends ChartView {
     }
 
     dispose() {
+        this.remove();
+
         this._controller && this._controller.dispose();
         this._controllerHost = null;
     }
@@ -300,7 +302,11 @@ class GraphView extends ChartView {
         this._lineDraw.updateLayout();
     }
 
-    remove(ecModel: GlobalModel, api: ExtensionAPI) {
+    remove() {
+        clearTimeout(this._layoutTimeout);
+        this._layouting = false;
+        this._layoutTimeout = null;
+
         this._symbolDraw && this._symbolDraw.remove();
         this._lineDraw && this._lineDraw.remove();
     }

diff --git a/test/graph-case.html b/test/graph-case.html
diff --git a/test/runTest/actions/__meta__.json b/test/runTest/actions/__meta__.json
diff --git a/test/runTest/actions/graph-case.json b/test/runTest/actions/graph-case.json