refactor(label): move unrelated code outside the state loop

apache · Nov 6, 2024 · 931326a · 931326a
1 parent d1b0d10
commit 931326a
Showing 1 changed file with 16 additions and 16 deletions.
diff --git a/src/label/LabelManager.ts b/src/label/LabelManager.ts
@@ -425,24 +425,24 @@ class LabelManager {
                 }
 
 
-                if (layoutOption.draggable) {
-                    label.draggable = true;
-                    label.cursor = 'move';
-                    if (hostEl) {
-                        let hostModel: Model<LabelLineOptionMixin> =
-                            labelItem.seriesModel as SeriesModel<LabelLineOptionMixin>;
-                        if (labelItem.dataIndex != null) {
-                            const data = labelItem.seriesModel.getData(labelItem.dataType);
-                            hostModel = data.getItemModel<LabelLineOptionMixin>(labelItem.dataIndex);
-                        }
-                        label.on('drag', createDragHandler(hostEl, hostModel.getModel('labelLine')));
+            }
+            if (layoutOption.draggable) {
+                label.draggable = true;
+                label.cursor = 'move';
+                if (hostEl) {
+                    let hostModel: Model<LabelLineOptionMixin> =
+                        labelItem.seriesModel as SeriesModel<LabelLineOptionMixin>;
+                    if (labelItem.dataIndex != null) {
+                        const data = labelItem.seriesModel.getData(labelItem.dataType);
+                        hostModel = data.getItemModel<LabelLineOptionMixin>(labelItem.dataIndex);
                     }
+                    label.on('drag', createDragHandler(hostEl, hostModel.getModel('labelLine')));
                 }
-                else {
-                    // TODO Other drag functions?
-                    label.off('drag');
-                    label.cursor = defaultLabelAttr.cursor;
-                }
+            }
+            else {
+                // TODO Other drag functions?
+                label.off('drag');
+                label.cursor = defaultLabelAttr.cursor;
             }
         }
     }