Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ukrainian locale name is incorrect #17795

Closed
manastyretskyi opened this issue Oct 19, 2022 · 2 comments · Fixed by #17800
Closed

Ukrainian locale name is incorrect #17795

manastyretskyi opened this issue Oct 19, 2022 · 2 comments · Fixed by #17800
Labels
bug en This issue is in English i18n

Comments

@manastyretskyi
Copy link

Version

5.4.0

Link to Minimal Reproduction

No response

Steps to Reproduce

Ukrainian locale code is "UK" and not "UA", as it is in version 5.4.0

Current Behavior

Locale code for Ukrainian language is "UA"

Expected Behavior

Locale code for Ukrainian language should be "UK"

Environment

- OS:
- Browser:
- Framework:

Any additional comments?

No response
@echarts-bot echarts-bot bot added en This issue is in English pending We are not sure about whether this is a bug/new feature. labels Oct 19, 2022
@manastyretskyi
Copy link
Author

Reference PR #17244

@plainheart
Copy link
Member

Thanks for your feedback! You are welcome to open a PR to fix it. :)

@plainheart plainheart added i18n and removed pending We are not sure about whether this is a bug/new feature. labels Oct 20, 2022
striezel added a commit to striezel-stash/echarts that referenced this issue Oct 20, 2022
@striezel
fix(i18n): language code for Ukrainian is UK, not UA
81cf154 
Closes apache#17795.
@striezel striezel mentioned this issue Oct 20, 2022
Merged
7 tasks
@striezel striezel mentioned this issue Oct 22, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug en This issue is in English i18n
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(i18n): language code for Ukrainian is UK, not UA striezel-stash/echarts
2 participants
@plainheart @manastyretskyi