Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i18n): rename language code of Ukrainian to UK #17812

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

striezel
Copy link
Contributor

This PR is a follow-up to #17800 and also moves the generated object files for the Ukrainian language.
I'm not sure whether this is really necessary, but better be safe than sorry here.

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Language code for Ukrainian language is UK, not UA, so the generated i18n object files are renamed accordingly.

Fixed issues

See #17795.

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

This commit also moves the generated object files.
I'm not sure whether this is really necessary, but better
be safe than sorry here.
@echarts-bot
Copy link

echarts-bot bot commented Oct 22, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@Ovilia Ovilia merged commit 3c11bf9 into apache:master Oct 25, 2022
@echarts-bot
Copy link

echarts-bot bot commented Oct 25, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia added this to the 5.4.1 milestone Oct 25, 2022
@striezel striezel deleted the i18n-ukrainian-language-code branch October 25, 2022 11:23
@plainheart plainheart changed the title fix(i18n): language code for Ukrainian is UK, not UA (follow-up) fix(i18n): rename language code of Ukrainian to UK Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants