-
Notifications
You must be signed in to change notification settings - Fork 19.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(label): fix labelLine default style when normal state not show but other state show #18800
Conversation
Thanks for your contribution! |
…t other state show
1926093
to
49e4008
Compare
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-18800@301b13d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the logic is all right but I'd prefer the way #19180 because setLabelLineState
is not a frequent operation and thus checking show
in all states can be ignored.
However, this PR gives a very solid test for it so I would also like to merge it. Can you revert the changes of src
and pull & merge from the master and submit again? Thanks!
I apologize for the delayed response. I am pleased to see that the bug has already been resolved, and I am willing to revert the code in the src directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for co-author the PR!
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Brief Information
This pull request is in the type of:
What does this PR do?
fix labelLine style not follow label style when normal state
show: false
, other stateshow: true
;Fixed issues
Details
Before: What was the problem?
when set normal state label show is false, and other state(such as emphasis) state label show: true
labelLine style cannot inherit sector color, and always
#000
After: How does it behave after the fixing?
although normal state label is show: false, but once any state has show: true, labelStyle will inhreit sector style
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information