fix(toolbox): fix toolbox title may be outside of the chart #16704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! The pull request is marked to be |
This was
linked to
issues
Mar 19, 2022
plainheart
commented
Mar 19, 2022
| @@ -307,7 +313,7 @@ class ToolboxView extends ComponentView { | |||
| emphasisTextConfig.position = 'top'; | |||
| needPutOnTop = true; | |||
| } | |||
| const topOffset = needPutOnTop ? (-5 - rect.height) : (itemSize + 8); | |||
| const topOffset = needPutOnTop ? (-5 - rect.height) : (itemSize + 10); | |||
There was a problem hiding this comment.
This is to make the adjusted y aligns with the one not adjusted. The original value 8 seems not perfact.
pissang
approved these changes
Mar 25, 2022
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Fix the toolbox title may be outside of the chart. This PR relies on #16702.
Fixed issues
Details
Before: What was the problem?
Toolbox title may be outside of the chart so that it can't be fully displayed.
After: How is it fixed in this PR?
Misc
Related test cases or examples to use the new APIs
See
test/toolbox-title.htmlOthers
Merging options
Other information