-
Notifications
You must be signed in to change notification settings - Fork 19.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sunburst): radial
rotation label might upside down
#18240
Conversation
Thanks for your contribution! The pull request is marked to be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot why startAngle
is not provided in the document, whether it's a bug or intentionally. Anyway, if this issue is to be accepted, we should also update the document.
I think it should be a good idea to use dat.gui
to dynamically change the startAngle
to check it works well with all situations. We also may need to restrict the range of valid startAngle
in the document.
|
Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the |
Ok, I will update it |
@Ovilia Test case has updated, thanks to your suggestion about |
LGTM but not sure why the lint CI failed. @susiwen8 Can you have a double-check? |
|
@Ovilia Ci has passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Ovilia Please take a look |
A little unexpected thing is that when the rotation of a text is changed by 360° (e.g., from 1 to 359), it has an animation of rotating the text. But I think we can ignore this for now and see if it's necessary to be fixed if some developers bring this up. |
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Brief Information
This pull request is in the type of:
What does this PR do?
sunbrust
label might upside down underradial
rotationFixed issues
Details
Before: What was the problem?
After: How does it behave after the fixing?
Document Info
One of the following should be checked.
startAngle
echarts-doc#337Misc
ZRender Changes
Related test cases or examples to use the new APIs
sunburst-label.html
Others
Merging options
Other information