Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tooltip): add
appendTo
option to allow customizing tooltip container #18436feat(tooltip): add
appendTo
option to allow customizing tooltip container #18436Changes from 5 commits
c4efc1f
e188b20
92bcf21
723e13b
a1b9d0f
19f68c5
77e48e4
d038881
eb8793f
efb00a7
aeff150
6ecd62b
368d0a8
7df2718
757877e
8d7aa91
de730f9
fd4ef78
2864cd1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the implementation of
appendToBody
is totally removed from the source code, it's better to remove this option instead of making it deprecated. This should be fixed in the future versions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ovilia The
appendToBody
option is not removed yet. See https://github.com/apache/echarts/pull/18436/files#diff-c4bf8caece88579c9e2ae0092955d9505397b706065a6dce98f5b74c7c7209baR175.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@plainheart OK. Thanks for correcting.