Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sunburst): label rotation problem when anticlockwise #19174

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

shiersansi
Copy link
Contributor

@shiersansi shiersansi commented Oct 6, 2023

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

This pr is used to fix a bug in the sunburst map where the lable position is incorrect when loaded counterclockwise

Fixed issues

[Bug] When the sunburst is anticlockwise, the leaf node text displays the problem externally #19050
https://github.com/apache/echarts/issues/19050

Before: What was the problem?

屏幕截图 2023-10-06 164717

After: How does it behave after the fixing?

屏幕截图 2023-10-06 164240

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Oct 6, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

⚠️ MISSING DOCUMENT INFO: Please make sure one of the document options are checked in this PR's description. Search "Document Info" in the description of this PR. This should be done either by the author or the reviewers of the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-19174@38ec1b5

@Ovilia Ovilia changed the title fix #19050 fix(sunburst): label rotation problem when anticlockwise Oct 8, 2023
@Ovilia Ovilia merged commit ea28e44 into apache:master Oct 8, 2023
2 checks passed
@echarts-bot
Copy link

echarts-bot bot commented Oct 8, 2023

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia added this to the 5.5.0 milestone Oct 8, 2023
@echarts-bot echarts-bot bot added PR: awaiting doc Document changes is required for this PR. and removed PR: doc unchanged labels Oct 29, 2023
@echarts-bot
Copy link

echarts-bot bot commented Oct 29, 2023

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: awaiting doc Document changes is required for this PR. PR: first-time contributor size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants