Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(calendar): add silent option for dayLabel/monthLabel/yearLabel #20492

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

plainheart
Copy link
Member

@plainheart plainheart commented Nov 9, 2024

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Add silent option for dayLabel/monthLabel/yearLabel to allow the users to disable the label interaction.

Demo

Fixed issues

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

See test/calendar-simple.html

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented Nov 9, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@plainheart plainheart changed the title feat(calendar): add silent option for dayLabel/monthLabel/yearLabel` feat(calendar): add silent option for dayLabel/monthLabel/yearLabel Nov 9, 2024
@plainheart plainheart added this to the 5.5.2 milestone Nov 9, 2024
Copy link

echarts-bot bot commented Nov 9, 2024

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

@echarts-bot echarts-bot bot added the PR: awaiting doc Document changes is required for this PR. label Nov 9, 2024
Copy link
Contributor

github-actions bot commented Nov 9, 2024

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20492@61f2e84

Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the doc for series.label.silent is missing for now, although it's supported. Can you also add the doc when you add doc for calendar labels?

@Ovilia Ovilia merged commit 2576fc2 into master Nov 15, 2024
2 checks passed
Copy link

echarts-bot bot commented Nov 15, 2024

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia deleted the feat/calendar-label-silent branch November 15, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: author is committer PR: awaiting doc Document changes is required for this PR. size/S
Projects
None yet
2 participants