-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Substitute e.printStackTrace()
with log.error()
#4733
Comments
Hi @Pil0tXia, I can fix this enhancement issue as well, would be happy to be assigned |
@MovieTone How about temporarily leaving this issue to someone else who is interested in contributing to open source? |
@Pil0tXia Yes, sure |
There is an OpenRewrite recipe for this: https://docs.openrewrite.org/recipes/java/logging/printstacktracetologerror You can also run it regularly to convert new call sites of |
@ppkarwasz Hah, I remember that. There are only three remaining usages of printStackTrace(), which can be resolved in a good first issue.😉 |
Hi @Pil0tXia, can you assign me this enhancement issue. |
@archit-8 Welcome to Apache EventMesh community! |
thanks, hey can you share path of a files where changes are going to happen. |
They are listed in the body of the issue already: |
@Pil0tXia This issue has finished? |
@mxsm Not yet. The assignee haven't submit a PR yet. |
replaced e.printStackTrace() with log.error()
replaced e.printStackTrace() with log.error()
Search before asking
Enhancement Request
e.printStackTrace()
should be substituted withlog.error()
in these classes:Describe the solution you'd like
Take
org.apache.eventmesh.runtime.client.impl.PubClientImpl
as an example:Are you willing to submit PR?
Code of Conduct
The text was updated successfully, but these errors were encountered: