[ISSUE #3010] Method manually handles closing an auto-closeable resource [MetaHandler] #4755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to the Apache EventMesh community!!
This is your first PR in our project. We're very excited to have you onboard contributing. Your contributions are greatly appreciated!
Please make sure that the changes are covered by tests.
We will be here shortly.
Let us know if you need any help!
Want to get closer to the community?
| WeChat Assistant | WeChat Public Account | Slack |
|---|---|---|
 |
 |
Join Slack Chat |
Mailing Lists:
| Name | Description | Subscribe | Unsubscribe | Archive |
|---|---|---|---|---|
| Users | User support and questions mailing list | Subscribe | Unsubscribe | Mail Archives |
| Development | Development related discussions | Subscribe | Unsubscribe | Mail Archives |
| Commits | All commits to repositories | Subscribe | Unsubscribe | Mail Archives |
| Issues | Issues or PRs comments and reviews | Subscribe | Unsubscribe | Mail Archives |
Pil0tXia
requested changes
Jan 21, 2024
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/admin/handler/MetaHandler.java
Outdated
Show resolved
Hide resolved
arsenalzp
force-pushed
the
refactorMetaHandler
branch
from
b66b310 to
15699bc
Compare
Pil0tXia
reviewed
Jan 23, 2024
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/admin/handler/MetaHandler.java
Show resolved
Hide resolved
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/admin/handler/MetaHandler.java
Show resolved
Hide resolved
Signed-off-by: Oleksandr Krutko <alexander.krutko@gmail.com> rewrite try-with-resources to use single object Signed-off-by: Oleksandr Krutko <alexander.krutko@gmail.com> trim comments Signed-off-by: Oleksandr Krutko <alexander.krutko@gmail.com>
arsenalzp
force-pushed
the
refactorMetaHandler
branch
from
15699bc to
8020e99
Compare
Pil0tXia
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3010.
Motivation
This change implements try-with-resources feature for get() method in MetaHandler class.
The try-with-resources statement ensures that each resource is closed at the end of the statement.
Modifications
Rewrite get() method to use try-with-resource statement, remove finally block.
Documentation