[ISSUE #4778] Fix Standalone MessageQueue does not down counter when dequeue #4779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pil0tXia
previously approved these changes
Feb 21, 2024
|
please fix ci |
Pil0tXia
reviewed
Feb 21, 2024
Comment on lines
238
to
240
| private MessageEntity dequeue() { | ||
| MessageEntity item = items[takeIndex++]; | ||
| final MessageEntity item = items[takeIndex++]; | ||
| if (takeIndex == items.length) { |
There was a problem hiding this comment.
What error is caused when this final decorator is missing? It seems to have fixed CI.
|
The development tool prompts that modifications like this can pass the style check. |
Pil0tXia
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4778
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.
Modifications
Describe the modifications you've done.
Documentation