FINERACT-1971: N plus one installment loan reschedule #3651
Conversation
| LoanScheduleModelPeriod lastInstallment = periods.get(periods.size() - 1); | ||
| // get end date for the schedule from loan charges | ||
| LocalDate scheduleDueDate = null; | ||
| if (!(BigDecimal.ZERO.compareTo(loanApplicationTerms.getAnnualNominalInterestRate()) < 0)) { |
There was a problem hiding this comment.
Can you please simplify this condition?
Negating whether annual nominal interest rate is higher than 0 is not easy to read.
Also interest rate cannot be negative.
There was a problem hiding this comment.
However i am not fully sure why does it matter whether there is interest or not...
There was a problem hiding this comment.
Hi Adam, here i tried to mimic the condition we have for add charge scenario in LoanChargeWritePlatformServiceImpl->addCharge, where for n+1 case we are checking whether the loan is interest bearing or not.
| final Collection<LoanTermVariationsData> interestRates = loanApplicationTerms.getLoanTermVariations() | ||
| .getInterestRateChanges(); | ||
|
|
||
| LocalDate periodStartDateApplicableForInterest = calculateInterestStartDateForPeriod(loanApplicationTerms, |
There was a problem hiding this comment.
I dont think we need to calculate interest after maturity date. @bharathc27 Thoughts?
There was a problem hiding this comment.
@bharathc27 Please comment.
There was a problem hiding this comment.
@ruchiD As discussed there is not interest calculcation involved for N+1 Installment that is after the maturity date.
N+1 Installment scenario happens only for 2 cases
- for charges - here user entered amount will be the installment amount
- for Charge-backs- here amounts are inherited from the repayment that charge-back was triggered from.
@adamsaghy cc
| @@ -410,6 +410,10 @@ private LoanScheduleModel generate(final MathContext mc, final LoanApplicationTe | |||
| scheduleParams.addTotalCumulativeInterest(totalInterest); | |||
| } | |||
|
|
|||
| // add charges only repayment schedule for charges with due date after maturity date (N+1) | |||
| addChargesOnlyRepaymentSchedule(currency, scheduleParams, periods, loanCharges, mc, loanApplicationTerms, transactions, | |||
There was a problem hiding this comment.
Is this only needed for cumulative loans? What about progressive ones?
There was a problem hiding this comment.
It is required for progressive ones also, but since interest handling, reschedule, prepayment and related stories for progressive schedule handling are pending i did not changed for progressive.
There was a problem hiding this comment.
does that mean if a progressive N+1 loan got rescheduled the N+1 charge will disappear?
There was a problem hiding this comment.
I will test and confirm.
There was a problem hiding this comment.
@adamsaghy, verified with latest, for progressive loans also N+1 installment vanishes after reschedule.
ruchiD
force-pushed
the
FINERACT-1971-N-plus-one-installment-loan-reschedule
branch
from
be51f75
to
6bce7e3
Compare
|
Made changes to Loan Repayment schedule transaction processors for adding N+1 installments, for loan reschedule cases. |
| @@ -78,6 +79,7 @@ public ChangedTransactionDetail reprocessLoanTransactions(final LocalDate disbur | |||
| } | |||
| } | |||
| } | |||
| addChargeOnlyRepaymentInstallmentIfRequired(charges, installments); | |||
There was a problem hiding this comment.
I dont really understand why we need this here.
I am assuming when we are reprocessing the transactions, the installments list containing all the installments including the N+1... no?
There was a problem hiding this comment.
@adamsaghy, when reschedule happens N+1 installment is not created/retained for loan installments and hence the issue. When reprocess is called after schedule regeneration we are adding the missing installment if required.
| if (!CollectionUtils.isEmpty(charges) && !CollectionUtils.isEmpty(installments)) { | ||
| LoanRepaymentScheduleInstallment latestRepaymentScheduleInstalment = installments.get(installments.size() - 1); | ||
| LocalDate installmentDueDate = null; | ||
| for (final LoanCharge loanCharge : charges) { |
There was a problem hiding this comment.
charges are a set, there is no order how you are iterating through on it, and it can happen multiple charges are after the last installment due date, no?
I would be happier if we were taking the latest charge which was after the maturity date and set that one instead of iterating though on them.
There was a problem hiding this comment.
Thanks, Will make this change.
ruchiD
force-pushed
the
FINERACT-1971-N-plus-one-installment-loan-reschedule
branch
from
6bce7e3
to
e90abc9
Compare
Description
Modifications for N+1 installment for loan reschedule for cumulative loan schedule generator.
Tests
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.