FINERACT-1981: Advanced payment allocation validation between Loan pr… #3663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsaghy
reviewed
Jan 3, 2024
| @@ -1705,4 +1709,20 @@ private void officeSpecificLoanProductValidation(final Long productId, final Lon | |||
| } | |||
| } | |||
|
|
|||
| private void validateTransactionProcessingStrategy(final LoanProduct loanProduct, final String loanRepaymentStrategy) { | |||
| if (loanProduct.getRepaymentStrategy().equals(LoanProductConstants.ADVANCED_PAYMENT_ALLOCATION_STRATEGY)) { | |||
There was a problem hiding this comment.
This one is not necessary true.
Just because the loan product was configured to advanced payment allocation, it does not mean the loan must be as well.
The rule is:
- If the loan product WAS NOT configured for advanced payment allocation, the loan CANNOT be 'advanced payment allocation`
- If the loan product WAS configured for advanced payment allocation, the loan CAN be advanced payment allocation OR ANYTHING ELSE, but if something else is selected the loan schedule type MUST be Cumulative.
- When the loan schedule type is CUMULATIVE, then Loan and loan product repayment strategy CANNOT be "advanced payment allocation".
- When the loan schedule type is PROGRESSIVE, then the loan and loan product repayment strategy MUST be only "advanced payment allocation".
I hope it helps!
There was a problem hiding this comment.
Done, code updated as:
// PROGRESSIVE: Repayment strategy MUST be only "advanced payment allocation"
if (loanProduct.getLoanProductRelatedDetail().getLoanScheduleType().equals(LoanScheduleType.PROGRESSIVE)) {
if (!transactionProcessingStrategyCode.equals(LoanProductConstants.ADVANCED_PAYMENT_ALLOCATION_STRATEGY)) {
throw new GeneralPlatformDomainRuleException(
"error.msg.loan.repayment.strategy.can.not.be.different.than.advanced.payment.allocation",
"Loan repayment strategy can not be different than Advanced Payment Allocation");
}
// CUMULATIVE: Repayment strategy CANNOT be "advanced payment allocation"
} else {
if (transactionProcessingStrategyCode.equals(LoanProductConstants.ADVANCED_PAYMENT_ALLOCATION_STRATEGY)) {
throw new GeneralPlatformDomainRuleException(
"error.msg.loan.repayment.strategy.can.not.be.equal.to.advanced.payment.allocation",
"Loan repayment strategy can not be equal to Advanced Payment Allocation");
}
}
adamsaghy
requested changes
Jan 3, 2024
josehernandezfintecheandomx
force-pushed
the
fix/repayment_strategy_loan_product_loan_account
branch
from
edb78d5
to
2c4b543
Compare
Done! Code updated and conflicts solved with the latest changes |
josehernandezfintecheandomx
force-pushed
the
fix/repayment_strategy_loan_product_loan_account
branch
from
2c4b543
to
6dbf461
Compare
josehernandezfintecheandomx
force-pushed
the
fix/repayment_strategy_loan_product_loan_account
branch
2 times, most recently
from
97b7bdb
to
2175d85
Compare
adamsaghy
reviewed
Jan 9, 2024
| break; | ||
| } | ||
| } | ||
| if (!existFinancialActivity) { |
There was a problem hiding this comment.
There was a problem hiding this comment.
@adamsaghy That IT was failing when there is already Financial Activity defined but no one of these is for Activity 200, so If the list has values but none one is for Activity 200 then It is created and the boolean flag is for controlling this
josehernandezfintecheandomx
force-pushed
the
fix/repayment_strategy_loan_product_loan_account
branch
from
2175d85
to
46b5d62
Compare
|
@josehernandezfintecheandomx Please dont forget to squash your commits! ;) |
…oduct and Loan account
josehernandezfintecheandomx
force-pushed
the
fix/repayment_strategy_loan_product_loan_account
branch
from
46b5d62
to
2adbf2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…oduct and Loan account
Description
Repayment strategy validation applied in the Loan account creation and modification, specifically when the Loan product uses Loan Schedule Type as
PROGRESSIVEChecklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.