FINERACT-1932: Fineract modularization - fineract-savings #3703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vidakovic
reviewed
Jan 24, 2024
| @@ -127,10 +126,6 @@ public final class SavingsAccountTransaction extends AbstractAuditableWithUTCDat | |||
| @Column(name = "reason_for_block", nullable = true) | |||
| private String reasonForBlock; | |||
|
|
|||
| @OneToMany(cascade = CascadeType.ALL, orphanRemoval = true) | |||
There was a problem hiding this comment.
I guess this is to reduce cross-dependencies to other domains? We should have more of these refactorings.
vidakovic
reviewed
Jan 24, 2024
| apply plugin: 'java' | ||
| apply plugin: 'eclipse' | ||
|
|
||
| compileJava.doLast { |
There was a problem hiding this comment.
Good for now. I'm sure we can come up with an idea to write it once instead of duplicating the same/similar configuration in multiple places. For another day.
vidakovic
approved these changes
Jan 24, 2024
alberto-art3ch
force-pushed
the
enhancement/new_fineract_savings_module
branch
from
9fddaa7
to
7d63d13
Compare
alberto-art3ch
force-pushed
the
enhancement/new_fineract_savings_module
branch
from
9add1a7
to
07f7512
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create the initial
fineract-savingsmodule - used to savings products and savings accounts module classes and interfacesFINERACT-1932
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.