Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FINERACT-2042: Reverse Replay Of Credit Allocations #3743

Conversation

reluxa
Copy link
Contributor

@reluxa reluxa commented Feb 12, 2024

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@reluxa reluxa force-pushed the FINERACT-2042-reverse-replay-of-credit-allocations branch from 451747b to 28196c8 Compare February 12, 2024 11:20
@reluxa reluxa changed the title Fineract 2042 reverse replay of credit allocations FINERACT-2042 Reverse Replay Of Credit Allocations Feb 12, 2024
@reluxa reluxa changed the title FINERACT-2042 Reverse Replay Of Credit Allocations FINERACT-2042: Reverse Replay Of Credit Allocations Feb 12, 2024
@reluxa reluxa force-pushed the FINERACT-2042-reverse-replay-of-credit-allocations branch from 28196c8 to 80a5164 Compare February 12, 2024 14:05
@reluxa reluxa force-pushed the FINERACT-2042-reverse-replay-of-credit-allocations branch from 80a5164 to 1c36c65 Compare February 12, 2024 17:16
@reluxa reluxa marked this pull request as ready for review February 12, 2024 17:17
Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reluxa reluxa merged commit 10c314e into apache:develop Feb 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants