Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FINERACT-2094 Upgrade to JDK 21 LTS #3918

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

IOhacker
Copy link
Contributor

@IOhacker IOhacker commented Jun 7, 2024

Description

Describe the changes made and why they were made.

Upgrade JDK 17 LTS to JDK 21 LTS
Upgrade Gradle file (Jib) for building in a JDK 21 LTS docker image.
Upgrade Github actions for using JDK 21 LTS

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@IOhacker
Copy link
Contributor Author

IOhacker commented Jun 7, 2024

@jdailey

@vidakovic
Copy link
Contributor

Just one caveat: we can run ON JDK 21, but we can not compile TO JDK 21 language version... Eclipse Link is only supporting Java 17. FYI

Copy link

github-actions bot commented Jul 9, 2024

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

@github-actions github-actions bot added the stale label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants