-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FINERACT-1932: Fineract modularization - fineract-job #3941
base: develop
Are you sure you want to change the base?
FINERACT-1932: Fineract modularization - fineract-job #3941
Conversation
@@ -20,10 +20,13 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes seems not relevant. Please remove it
@@ -300,14 +300,13 @@ public LoanTransactionData(Long id, LoanTransactionEnumData transactionType, Loc | |||
public static LoanTransactionData loanTransactionDataForDisbursalTemplate(final LoanTransactionEnumData transactionType, | |||
final LocalDate expectedDisbursedOnLocalDateForTemplate, final BigDecimal disburseAmountForTemplate, | |||
final BigDecimal netDisbursalAmount, final Collection<PaymentTypeData> paymentOptions, final BigDecimal retriveLastEmiAmount, | |||
final LocalDate possibleNextRepaymentDate) { | |||
final LocalDate possibleNextRepaymentDate, final CurrencyData currency) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes seems not relevant. Please remove it
@@ -539,7 +539,9 @@ public LoanTransactionData retrieveNewClosureDetails() { | |||
@Override | |||
public LoanApprovalData retrieveApprovalTemplate(final Long loanId) { | |||
final Loan loan = this.loanRepositoryWrapper.findOneWithNotFoundDetection(loanId, true); | |||
return new LoanApprovalData(loan.getProposedPrincipal(), DateUtils.getBusinessLocalDate(), loan.getNetDisbursalAmount()); | |||
final CurrencyData currencyData = new CurrencyData(loan.getCurrencyCode()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes seems not relevant. Please remove it
Description
Create the initial fineract-job modules - used as batch job domain module classes, interfaces and services
FINERACT-1932
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.