Migrate to Playwright #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has checked 115 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 80 | 16 | 19 | 0 |
Click to see the invalid file list
- build/UserALEWebExtension/background.d.ts
- build/UserALEWebExtension/background.js
- build/UserALEWebExtension/content.d.ts
- build/UserALEWebExtension/globals.d.ts
- build/UserALEWebExtension/messageTypes.d.ts
- build/UserALEWebExtension/options.d.ts
- build/attachHandlers.d.ts
- build/configure.d.ts
- build/getInitialSettings.d.ts
- build/main.d.ts
- build/packageLogs.d.ts
- build/sendLogs.d.ts
- build/utils/auth/index.d.ts
- build/utils/headers/index.d.ts
- build/utils/index.d.ts
- test/e2e/package.config.ts
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
EandrewJones
requested changes
Jun 13, 2024
EandrewJones
approved these changes
Jul 2, 2024
| const config = res.useraleConfig; | ||
| browser.storage.local.get([configKey], (res) => { | ||
| const payload = res[configKey]; | ||
| console.log(payload); |
src/types.d.ts
Outdated
| @@ -154,7 +154,7 @@ export declare namespace Callbacks { | |||
| export declare namespace Extension { | |||
| export type PluginConfig = { urlWhitelist: string }; | |||
| export type ConfigPayload = { | |||
| useraleConfig: Settings.Config; | |||
| useraleConfig: Settings.Config<Partial>; | |||
There was a problem hiding this comment.
Is this supposed to be a partial over Settings.Config.... I've never seen this syntax. If so, shouldn't it be:
Partial<Settings.Config>??
| @@ -17,7 +17,7 @@ | |||
| <!doctype html> | |||
| <html> | |||
| <head> | |||
| <script src="../build/userale-2.4.0.min.js"></script> | |||
| <script src="../../../build/userale-2.4.0.min.js"></script> | |||
There was a problem hiding this comment.
We ought to remove version numbering from our build artifacts, otherwise every time we bump a version, all these tests break/go stale...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.