Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-35831] Rotate jobId for both savepoint and stateless deploys #852

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

gyfora
Copy link
Contributor

@gyfora gyfora commented Jul 14, 2024

What is the purpose of the change

Job Ids can and should be rotated on savepoint redeployments as well. It is only important to keep the jobId when we are relying on recovery from HA metadata during last-state restore.

Brief change log

  • Change jobid rotation logic from stateless only to (not last-state)

Verifying this change

Unit tests, existing e2es

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changes to the CustomResourceDescriptors: no
  • Core observer or reconciler logic that is regularly executed: yes

Documentation

  • Does this pull request introduce a new feature? no

@gaborgsomogyi
Copy link
Contributor

Restarted the failed job, the change looks good.

@gyfora gyfora merged commit 2b82a93 into apache:main Jul 15, 2024
169 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants