[FLINK-36110][snapshot] Store periodic snapshot trigger timestamps in memory #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateczagany
force-pushed
the
FLINK-36110
branch
from
f7d4ce4
to
4811b19
Compare
mateczagany
commented
Aug 20, 2024
...va/org/apache/flink/kubernetes/operator/reconciler/deployment/ApplicationReconcilerTest.java
Show resolved
Hide resolved
mateczagany
force-pushed
the
FLINK-36110
branch
from
4811b19
to
ad1b33e
Compare
mateczagany
force-pushed
the
FLINK-36110
branch
from
ad1b33e
to
2d7bf56
Compare
gyfora
reviewed
Aug 20, 2024
...main/java/org/apache/flink/kubernetes/operator/reconciler/SnapshotTriggerTimestampStore.java
Outdated
Show resolved
Hide resolved
gyfora
reviewed
Aug 21, 2024
...n/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractJobReconciler.java
Outdated
Show resolved
Hide resolved
...n/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractJobReconciler.java
Outdated
Show resolved
Hide resolved
…ng to PR comments
gyfora
reviewed
Aug 22, 2024
Comment on lines
81
to
92
| .orElseGet( | ||
| () -> { | ||
| var legacyTs = getLegacyTimestamp(resource, snapshotType); | ||
| var creationTs = | ||
| Instant.parse(resource.getMetadata().getCreationTimestamp()); | ||
|
|
||
| if (legacyTs.compareTo(creationTs) > 0) { | ||
| return legacyTs; | ||
| } else { | ||
| return creationTs; | ||
| } | ||
| }); |
There was a problem hiding this comment.
Should we put into the cache before returning?
There was a problem hiding this comment.
I like this idea, with this change we won't unnecessarily call the supplier if we don't trigger a periodic snapshot in AbstractJobReconciler.
...main/java/org/apache/flink/kubernetes/operator/reconciler/SnapshotTriggerTimestampStore.java
Show resolved
Hide resolved
...n/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractJobReconciler.java
Outdated
Show resolved
Hide resolved
gyfora
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
SnapshotObserver uses deprecated fields as the latest timestamp of triggered snapshots. These fields are not updated when using FlinkStateSnapshot though. This new method of storing these timestamps is meant to fix this case.
Brief change log
Verifying this change
Does this pull request potentially affect one of the following parts:
CustomResourceDescriptors: noDocumentation