-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-35334][flink-table] Split constructor of generated code if it is too large. #25644
[FLINK-35334][flink-table] Split constructor of generated code if it is too large. #25644
Conversation
59a6449
to
17c90bf
Compare
@flinkbot run azure |
17c90bf
to
9c74661
Compare
@flinkbot run azure |
there was a bug in the past which is the reason of failure |
9c74661
to
c49245b
Compare
@flinkbot run azure |
1 similar comment
@flinkbot run azure |
@snuyanzin I rebase the newest |
Thanks for your contribution @littleeleventhwolf |
@snuyanzin Thanks for your review. I create backports in #25688 and #25689 . PTAL. |
What is the purpose of the change
This pull request aims to split constructor of generated code if it is too large to be compiled.
Brief change log
Verifying this change
Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.
This change is already covered by existing tests, such as org.apache.flink.table.codesplit.JavaCodeSplitterTest#testSplitJavaCode.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation