Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-35334][flink-table] Split constructor of generated code if it is too large. #25644

Merged

Conversation

littleeleventhwolf
Copy link
Contributor

What is the purpose of the change

This pull request aims to split constructor of generated code if it is too large to be compiled.

Brief change log

  • Override visitConstructorDeclaration to split it into multiple void functions.

Verifying this change

Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.

This change is already covered by existing tests, such as org.apache.flink.table.codesplit.JavaCodeSplitterTest#testSplitJavaCode.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 12, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@littleeleventhwolf
Copy link
Contributor Author

@flinkbot run azure

@littleeleventhwolf littleeleventhwolf force-pushed the fix/large-codegen-constructor branch from 17c90bf to 9c74661 Compare November 18, 2024 06:30
@littleeleventhwolf
Copy link
Contributor Author

@flinkbot run azure

@snuyanzin
Copy link
Contributor

there was a bug in the past which is the reason of failure
can you rebase it to be sure ci is passed?

@littleeleventhwolf littleeleventhwolf force-pushed the fix/large-codegen-constructor branch from 9c74661 to c49245b Compare November 25, 2024 02:21
@littleeleventhwolf
Copy link
Contributor Author

@flinkbot run azure

1 similar comment
@littleeleventhwolf
Copy link
Contributor Author

@flinkbot run azure

@littleeleventhwolf
Copy link
Contributor Author

@snuyanzin I rebase the newest master branch and CI is passed.

@snuyanzin
Copy link
Contributor

Thanks for your contribution @littleeleventhwolf
it looks good to me
can you please also create backports (1.19, 1.20) and then all could be merged

@littleeleventhwolf
Copy link
Contributor Author

@snuyanzin Thanks for your review. I create backports in #25688 and #25689 . PTAL.

@snuyanzin snuyanzin merged commit 9b8c0e2 into apache:master Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants