Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-13374][scala][build] Set -Xss2m when compiling scala #9315

Merged
merged 1 commit into from
Aug 1, 2019

Conversation

zentol
Copy link
Contributor

@zentol zentol commented Aug 1, 2019

This PR bumps the ThreadStackSize to 2MB when compiling scala. This appears to be the common approach for handling StackOverflowErrors by the scala compiler.

see https://www.scala-lang.org/old/node/10931, scala/bug#10604

I haven't observed an increase in compile time.

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 1, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 1, 2019

CI report:

@zentol zentol merged commit 1dd6405 into apache:master Aug 1, 2019
@zentol zentol deleted the 13374 branch August 6, 2019 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants