Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] add github workflow #100

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Conversation

bmarwell
Copy link
Contributor

@bmarwell bmarwell commented Nov 4, 2023

Just a suggestion. This way further pull requests will automatically be checked.

@bmarwell bmarwell marked this pull request as draft November 4, 2023 13:04
@bmarwell bmarwell force-pushed the github_workflows branch 6 times, most recently from 836facf to 3ac52b8 Compare November 4, 2023 13:47
@bmarwell
Copy link
Contributor Author

bmarwell commented Nov 4, 2023

Because of the prompt, I was not able to add the "dist" goal. However, the signing could be done by a passphrase-less gpg key. This is needed for a rat-check. Skipped it for now.

@bmarwell bmarwell marked this pull request as ready for review November 4, 2023 13:49
@bmarwell
Copy link
Contributor Author

bmarwell commented Nov 4, 2023

Tests with other JDKs (11, 17, 21) can be added in another commit, if you are interested.

@ddekany
Copy link
Contributor

ddekany commented Nov 4, 2023

Thanks! BTW, Travis ran very long ago, when it was still free, but it's green build icon is still there. If there something like that Git actions, it should be replaced to with that.

@bmarwell
Copy link
Contributor Author

bmarwell commented Nov 4, 2023

Sure! Can do that in another PR, preferably. Otherwise I'd do it blindly.

I would love to add the "ant dist" target. The only thing I can't do is "answer yes" on the last question.
I don't know much ant. But maybe we could add a build property which skips the interactive question on CI builds?

Copy link
Contributor Author

@bmarwell bmarwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should also remove Travis.

.github/workflows/ant.yml Outdated Show resolved Hide resolved
@bmarwell
Copy link
Contributor Author

bmarwell commented Nov 5, 2023

We can add a cache in a later PR, but for now this should be fine. Maybe not even worth it as the project is heading towards Gradle.

@ddekany
Copy link
Contributor

ddekany commented Nov 6, 2023

We don't need ant dist, but ant ci, which I see you have discovered. If we want to test more, it should be added to ci. But, yes, these will go away with the Gradle PR anyway. (There's also Github actions prepared for that by the author of the Gradle PR).

@ddekany ddekany merged commit e571099 into apache:2.3-gae Nov 6, 2023
1 check passed
@bmarwell bmarwell deleted the github_workflows branch November 6, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants