Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XBEAN-341] Upgrade ASM from 9.5 to 9.6 #39

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

LuciferYang
Copy link
Contributor

This pr aims to upgrade ASM from 9.5 to 9.6, the new version is for Java 22.

@LuciferYang
Copy link
Contributor Author

Local check mvn clean install with Java 8, all tests can pass.

@fpapon fpapon self-requested a review October 11, 2023 09:10
Copy link
Member

@fpapon fpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@LuciferYang thanks for your contribution!

@fpapon fpapon merged commit 255ab1a into apache:trunk Oct 11, 2023
@LuciferYang
Copy link
Contributor Author

Thanks @fpapon ~

@fpapon
Copy link
Member

fpapon commented Oct 11, 2023

Release should be perfomed soon

LuciferYang added a commit to apache/spark that referenced this pull request Oct 20, 2023
### What changes were proposed in this pull request?
This PR aims to upgrade ASM to 9.6.

### Why are the changes needed?
xbean-asm9-shaded 4.24 upgrade to use ASM 9.6 and ASM 9.6 is for Java 22:

- https://asm.ow2.io/versions.html
- https://issues.apache.org/jira/browse/XBEAN-341 | apache/geronimo-xbean#39

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Pass GitHub Actions

### Was this patch authored or co-authored using generative AI tooling?
No

Closes #43431 from LuciferYang/SPARK-45591.

Authored-by: yangjie01 <yangjie01@baidu.com>
Signed-off-by: yangjie01 <yangjie01@baidu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants