Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GOBBLIN-1818] initilaize yarn clients in yarn app launcher so that a child class can override the yarn client creation logic #3679

Merged
merged 1 commit into from
Apr 17, 2023
Merged

[GOBBLIN-1818] initilaize yarn clients in yarn app launcher so that a child class can override the yarn client creation logic #3679

merged 1 commit into from
Apr 17, 2023

Conversation

arjun4084346
Copy link
Contributor

@arjun4084346 arjun4084346 commented Apr 17, 2023 •
edited
Loading

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    Moved the logic of creating yarn clients out of the constructors, because child class variables are not initialized until super class is created and hence it cannot use it's own initialized variables in modifying logic in overriden methods.
    This is in the continuation of [GOBBLIN-1815] Refactor yarn app launchers to support extending these classes #3671 work

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    trivial changes

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@arjun4084346 arjun4084346 force-pushed the rm-2-yarn-client-refactoring branch from e3a3d23 to b34be7b Compare April 17, 2023 17:11
@arjun4084346 arjun4084346 changed the title initiliaze yarn clients in yarn app launcher so that a child class ca… initiliaze yarn clients in yarn app launcher so that a child class can override the yarn client creation logic Apr 17, 2023
jack-moseley
jack-moseley approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@jack-moseley jack-moseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arjun4084346 arjun4084346 changed the title initiliaze yarn clients in yarn app launcher so that a child class can override the yarn client creation logic [GOBBLIN-1818] initilaize yarn clients in yarn app launcher so that a child class can override the yarn client creation logic Apr 17, 2023
@Will-Lo Will-Lo merged commit 7deea30 into apache:master Apr 17, 2023
phet added a commit to phet/gobblin that referenced this pull request Aug 15, 2023
@phet
Merge remote-tracking branch 'upstream/master'
90dd1ff 
* upstream/master:
  [GOBBLIN-1832] Emit warning instead of failing job for retention of Hive Table Views (apache#3695)
  [GOBBLIN-1831] Use flowexecutionid in kafka monitor and jobnames (apache#3694)
  [GOBBLIN-1824]Improving the Efficiency of Work Planning in Manifest-Based DistCp Jobs (apache#3686)
  [GOBBLIN-1829] Fixes bug where the wrong workunit event was being tracked for keepin… (apache#3691)
  [GOBBLIN-1828] Implement Timeout for Creating Writer Functionality (apache#3690)
  [GOBBLIN-1827] Add check that if nested field is optional and has a non-null default… (apache#3689)
  [GOBBLIN-1826] Change isAssignableFrom() to isSuperTypeOf() per Guava 20 javadocs to… (apache#3688)
  [GOBBLIN-1822]Logging Abnormal Helix Task States (apache#3685)
  [GOBBLIN-1819] Log helix workflow information and timeout information during submission wait / polling (apache#3681)
  [GOBBLIN-1821] Let flow execution ID propagate to the Job ID if it exists (apache#3684)
  [GOBBLIN-1810] Support general iceberg catalog (support configurable behavior for metadata retention policy) (apache#3680)
  Add null default value to observability events that are additionally added (apache#3682)
  [GOBBLIN-1816] Add job properties and GaaS instance ID to observability event (apache#3676)
  [GOBBLIN-1785] add MR_JARS_BASE_DIR and logic to delete old mr jar dirs (apache#3642)
  initiliaze yarn clients in yarn app launcher so that a child class can override the yarn client creation logic (apache#3679)
  [GOBBLIN-1811]Fix Iceberg Registration Serialization (apache#3673)
  [GOBBLIN-1817] change some deprecated code and fix minor codestyle (apache#3678)
  [GOBBLIN-1812] Mockito should only be test compile (apache#3674)
  [GOBBLIN-1813] Helix workflows submission timeouts are configurable (apache#3677)
  [GOBBLIN-1810] Support general iceberg catalog in icebergMetadataWriter (apache#3672)
  Refactor yarn app launchers to support extending these classes (apache#3671)
  [GOBBLIN-1808] Bump Guava version from 15.0 to 20.0 (apache#3669)
  [GOBBLIN-1806] Submit dataset summary event post commit and integrate them into GaaSObservabilityEvent (apache#3667)
  [GOBBLIN-1814] Add `MRJobLauncher` configurability for any failing mapper to be fatal to the MR job (apache#3675)
  Add new lookback version finder for use with iceberg retention (apache#3670)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jack-moseley jack-moseley jack-moseley approved these changes

@Will-Lo Will-Lo Will-Lo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arjun4084346 @Will-Lo @jack-moseley