Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-1929] add dataset root in some common type of datasets #3802

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

arjun4084346
Copy link
Contributor

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

This PR adds dataset path in IcebergDataset and RecursiveCopyableDataset , which is one of the most commonly used dataset type in distcp jobs. dataset path is needed by datasethandler to find the shard path.

JIRA

Description

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    trivial changes, tested manually

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@arjun4084346 arjun4084346 changed the title add dataset root in some common type of datasets [GOBBLIN-1929] add dataset root in some common type of datasets Oct 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2023

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 47.33%. Comparing base (9b254b6) to head (eb97184).
Report is 233 commits behind head on master.

Files with missing lines Patch % Lines
...n/data/management/copy/iceberg/IcebergDataset.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3802      +/-   ##
============================================
- Coverage     47.37%   47.33%   -0.04%     
- Complexity    10973    10976       +3     
============================================
  Files          2152     2152              
  Lines         85154    85179      +25     
  Branches       9470     9472       +2     
============================================
- Hits          40341    40319      -22     
- Misses        41155    41203      +48     
+ Partials       3658     3657       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arjun4084346 arjun4084346 merged commit cea7cda into apache:master Oct 18, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants