Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-1935] Skip null dag action types unable to be processed #3807

Merged
merged 2 commits into from
Oct 25, 2023
Merged

[GOBBLIN-1935] Skip null dag action types unable to be processed #3807

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
198ad7f
Skip over null dag actions from malformed messages
Oct 24, 2023
0ab052a
Add new metric for skipped messages
Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...vice/src/main/java/org/apache/gobblin/service/monitoring/DagActionStoreChangeMonitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,12 @@ protected void processMessage(DecodeableKafkaRecord message) {
String flowName = value.getFlowName();
String flowExecutionId = value.getFlowExecutionId();

if (value.getDagAction() == null) {
log.warn("Skipping null dag action type received for flow group: {} name: {} executionId: {} tid: {} operation: "
+ "{}", flowGroup, flowName, flowExecutionId, tid, operation);
this.messageFilteredOutMeter.mark();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it make sense to mix w/ what this is already tracking?

return;
}
DagActionStore.FlowActionType dagActionType = DagActionStore.FlowActionType.valueOf(value.getDagAction().toString());

produceToConsumeDelayValue = calcMillisSince(produceTimestamp);
Expand Down