Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-2109] Fix minor permission issues with setPermissionCommitStep in Manifest distcp #4000

Conversation

Will-Lo
Copy link
Contributor

@Will-Lo Will-Lo commented Jul 13, 2024

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    This PR adds some minor fixes to ensure that permissions setting in Manifest distcp correctly resets folder permissions after adding execute bit along with tests, and ensures that the ownerAndPermission list is reset in between the writers and the commit step by using list iterator

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Unit tests

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

…erator is distinct, and fix setPermissionCommitStep which had an empty map
@Will-Lo Will-Lo merged commit 726f43f into apache:master Jul 17, 2024
6 checks passed
@Will-Lo Will-Lo deleted the reset-owner-iterator-manifest-distcp-fix-set-permission branch July 17, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants