[GOBBLIN-2113] Process Heartbeat DagAction CDC messages with empty FlowExecutionId str #4004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4004 +/- ##
=========================================
Coverage 38.72% 38.72%
Complexity 1596 1596
=========================================
Files 388 388
Lines 15957 15957
Branches 1578 1578
=========================================
Hits 6180 6180
Misses 9283 9283
Partials 494 494 ☔ View full report in Codecov by Sentry. |
| @@ -150,7 +150,7 @@ public void testProcessMessageWithHeartbeatAndNullDagAction() throws SpecNotFoun | |||
| @Test (dependsOnMethods = "testProcessMessageWithHeartbeatAndNullDagAction") | |||
| public void testProcessMessageWithHeartbeatAndFlowInfo() throws SpecNotFoundException { | |||
| Kafka09ConsumerClient.Kafka09ConsumerRecord consumerRecord = | |||
| wrapDagActionStoreChangeEvent(OperationType.HEARTBEAT, FLOW_GROUP, FLOW_NAME, FLOW_EXECUTION_ID, DagActionValue.RESUME); | |||
| wrapDagActionStoreChangeEvent(OperationType.HEARTBEAT, "", "", "", DagActionValue.RESUME); | |||
There was a problem hiding this comment.
is this a real case? can a heartbeat message not have flow name and have dag action?
There was a problem hiding this comment.
Not a real case but wanted to check some edge case behavior
arjun4084346
approved these changes
Jul 16, 2024
|
checks on my branch umustafi#34 |
Will-Lo
reviewed
Jul 16, 2024
| if (!jobExecutionPlanDagOptional.isPresent()) { | ||
| return Optional.absent(); | ||
| } | ||
| try { |
There was a problem hiding this comment.
Do we still want the try/catch here?
Will-Lo
reviewed
Jul 16, 2024
| flowCompilationTimer.stop(flowMetadata); | ||
| return jobExecutionPlanDagOptional; | ||
| } catch (IOException e) { | ||
| log.error("Encountered exception when attempting to compile and perform checks for flow: {}", flowSpec); |
There was a problem hiding this comment.
If you want to log this out maybe only print out the flowspec IDs
Will-Lo
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
After changing
flowExecutionIdfrom a Str to a long in a previous PR, we encounterNumberFormatExceptionin theDagActionStoreChangeMonitorwhen processing HB events. This ends up killing theHighLevelConsumerqueues for the hosts that receive the HB events in their partition.Tests
Updates the following unit test for Heartbeat (HB) events which was using valid flow names, groups, and flowExecutionId for HB event that did not accurately reflect a HB event received from CDC. After updating its values the test failed locally
It passes after the update.
Commits