Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-2116] Update Hive retention to add table location to retention dataset root… #4006

Conversation

Will-Lo
Copy link
Contributor

@Will-Lo Will-Lo commented Jul 18, 2024

… property

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    In Iceberg and File retention, the field FsCleanableHelper.RETENTION_DATASET_ROOT is added in order to send metadata about the table to the retention job to compute trash locations. We want to maintain this behavior for Hive retention.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Adding property only

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@Will-Lo Will-Lo changed the title Update Hive retention to add table location to retention dataset root… [GOBBLIN-2116] Update Hive retention to add table location to retention dataset root… Jul 18, 2024
@Will-Lo Will-Lo merged commit 6aa6530 into apache:master Jul 18, 2024
6 checks passed
@Will-Lo Will-Lo deleted the hive-retention-finder-add-root-property-dataset-level branch July 18, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants