[GOBBLIN-2119] ignore adding deadline dag actions if they are already present #4008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umustafi
reviewed
Jul 23, 2024
| dagManagementStateStore.addDagAction(dagAction); | ||
| } catch (IOException e) { | ||
| if (e.getCause() != null && e.getCause() instanceof SQLIntegrityConstraintViolationException) { | ||
| dagManagementStateStore.deleteDagAction(dagAction); |
There was a problem hiding this comment.
why delete then re-add? is this to trigger CDC again?
There was a problem hiding this comment.
The intention is to have a deadline dag proc with the new deadline time.
There was a problem hiding this comment.
I see so we try launching same job but want to ensure the deadline is updated to reflect newer launch or at least that there's a deadline in memory for it
There was a problem hiding this comment.
for the metrics on startup it will show up as several deletions and additions but I think this is ok. no negative values
umustafi
approved these changes
Jul 23, 2024
arjun4084346
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
If the service restarts before we call conclude on the lease, the deadline dag actions may get entered into the dag action store. The launch dag task (that creates deadline dag actions) will be retried on service start. It is not ideal to launch a job twice. When the job is launched again, it tries to store the deadline dag actions again and fails due to Primary Key constraint. We should ignore this exception otherwise the job submission will keep on being retried.
Tests
trivial changes
Commits