Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5520] improvement(JDBC-connection): handle JDBC access denied exception #5546

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mchades
Copy link
Contributor

@mchades mchades commented Nov 12, 2024

What changes were proposed in this pull request?

catch JDBC access denied exception and convert to UnauthorizedException

Why are the changes needed?

The REST client need the real exception instead of GravitinoRuntimeException

Fix: #5520

Does this PR introduce any user-facing change?

no

How was this patch tested?

ITs added

@jerryshao
Copy link
Contributor

Is it ready for review?

jerryshao
jerryshao previously approved these changes Nov 12, 2024
@jerryshao
Copy link
Contributor

@yuqi1129 can you please also take a look?

@yuqi1129
Copy link
Contributor

@yuqi1129 can you please also take a look?

Got it.

@jerryshao
Copy link
Contributor

@yuqi1129 @jerqi please help to review again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] JdbcExceptionConverter does not handle AccessDeniedException
3 participants