-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#5336] feat(auth-ranger): Remove MANAGED_BY_GRAVITINO limit and compatible for existing ranger policy #5629
Conversation
hi @theoryxu Thank you for your attention to this problem The problem now is that Gravitino will only maintain a Ranger Policy with the
But that's a pretty big limitation.
|
… compatible for existing ranger policy
f2f328b
to
642983d
Compare
...thorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerHelper.java
Outdated
Show resolved
Hide resolved
...thorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerHelper.java
Outdated
Show resolved
Hide resolved
...thorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerHelper.java
Outdated
Show resolved
Hide resolved
… compatible for existing ranger policy
...thorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerHelper.java
Outdated
Show resolved
Hide resolved
...thorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerHelper.java
Outdated
Show resolved
Hide resolved
...thorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerHelper.java
Outdated
Show resolved
Hide resolved
...thorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerHelper.java
Outdated
Show resolved
Hide resolved
...thorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerHelper.java
Show resolved
Hide resolved
… compatible for existing ranger policy
… compatible for existing ranger policy
… compatible for existing ranger policy
...thorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerHelper.java
Show resolved
Hide resolved
… compatible for existing ranger policy
… compatible for existing ranger policy
… compatible for existing ranger policy
… compatible for existing ranger policy
… compatible for existing ranger policy
… compatible for existing ranger policy
...thorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerHelper.java
Outdated
Show resolved
Hide resolved
...thorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerHelper.java
Outdated
Show resolved
Hide resolved
...thorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerHelper.java
Outdated
Show resolved
Hide resolved
...thorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerHelper.java
Outdated
Show resolved
Hide resolved
...thorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerHelper.java
Outdated
Show resolved
Hide resolved
...r/src/test/java/org/apache/gravitino/authorization/ranger/integration/test/RangerHiveIT.java
Outdated
Show resolved
Hide resolved
...r/src/test/java/org/apache/gravitino/authorization/ranger/integration/test/RangerHiveIT.java
Outdated
Show resolved
Hide resolved
...r/src/test/java/org/apache/gravitino/authorization/ranger/integration/test/RangerHiveIT.java
Outdated
Show resolved
Hide resolved
...r/src/test/java/org/apache/gravitino/authorization/ranger/integration/test/RangerHiveIT.java
Outdated
Show resolved
Hide resolved
...r/src/test/java/org/apache/gravitino/authorization/ranger/integration/test/RangerHiveIT.java
Outdated
Show resolved
Hide resolved
… compatible for existing ranger policy
… compatible for existing ranger policy
@xunliu all flaws have been fixed. Please review it again. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What changes were proposed in this pull request?
Many clients and users have used Ranger for a while. Gravitino should be compatible with these cases.
There are some principles Gravitino needs to follow when it pushes down policies:
For the target, this PR includes the following changes:
wildcardSearchPolies
removes theMANAGED_BY_GRAVITINO
filter.GRAVITINO_
.Despite doing these, users should be cautious about directly managing the ranger policy. There are some restricts:
Why are the changes needed?
Fix: #5336
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
Added ITs