Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUACAMOLE-925: Add Russian keymap support "ru-ru-qwerty" #574

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

VAGurko
Copy link

@VAGurko VAGurko commented Jan 15, 2025

The keymap "ru_ru_qwerty.keymap" has been added to the "src/protocols/rdp/Makefile.am" file to support the Russian keyboard layout.
The file "src/protocols/rdp/keymaps/ru_ru_qwerty.keymap" has been added to support the Russian keyboard layout.

The keymap "ru_ru_qwerty.keymap" has been added to the "src/protocols/rdp/Makefile.am" file to support the Russian keyboard layout.
The file "src/protocols/rdp/keymaps/ru_ru_qwerty.keymap" has been added to support the Russian keyboard layout.
map +caps -shift 0x2C..0x35 ~ "ЯЧСМИТЬБЮ,"

map +caps +shift 0x29 0x02..0x0D ~ "ё!"№;%:?*()_+"
map +caps +shift 0x10..0x1B 0x2B ~ "йцукенгшщзхъ/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This (and other lines) duplicates the same scancodes and modifier combination as a previous line:

map +caps +shift 0x10..0x1B 0x2B ~ "qwertyuiop{}|"

There needs to be something that distinguishes the context of typing these characters for the mapping to work correctly. For example, if the user presses "q" or "й", this map will result in the same sequence of scancodes being sent, but that sequence will not necessarily be interpreted to produce "q" (or "й"). Proper behavior will depend on some sort of additional state that Guacamole isn't aware of, and the intent of the user may not match what ultimately ends up typed.

Is there something else that needs to be supported by these keymaps for this to be unambiguous? Does the Russian keyboard have additional modifier keys or state that needs to be represented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants