Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] upgrade GitHub actions because old versions no longer work reliably #39

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented Sep 25, 2024

See broken build for #38

Example:

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-java@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default

GitHub are removing support for Node 16 (and older) and the old CI actions used by this project use Node 12 and 16.

'adopt' JDKs have been rebranded as 'temurin' - https://adoptium.net/en-GB/temurin/releases/

@pjfanning pjfanning changed the title [MINOR] upgrade GitHub actions because old versions no longer work reliably [BUILD] upgrade GitHub actions because old versions no longer work reliably Sep 25, 2024
@pjfanning
Copy link
Contributor Author

@steveloughran @ayushtkn @slfan1989 This fixes the CI issues in this project. I'm looking to get #38 merged because of a CVE in protobuf-java.

Copy link
Contributor

@steveloughran steveloughran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@steveloughran steveloughran merged commit 95fb8f3 into apache:trunk Sep 25, 2024
3 checks passed
@pjfanning pjfanning deleted the broken-CI branch September 25, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants