-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-19415. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-common Part5. #7357
Conversation
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
007ba03
to
50f43c6
Compare
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@cnauroth Could you please help review this PR? Thank you very much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 Thank you, @slfan1989 !
028daf5
to
7d361f3
Compare
🎊 +1 overall
This message was automatically generated. |
@cnauroth Thank you very much for reviewing the code! Part5 has successfully passed the Yetus verification with a positive result. I will merge this PR into the trunk branch and start preparing the code for Part6. Since Part6 involves dependency management and the project's dependencies are quite complex, multiple PRs may be needed to complete it. I will try to keep each submission around 100 classes while ensuring the integrity of the modules. |
🎊 +1 overall
This message was automatically generated. |
Description of PR
JIRA: HADOOP-19415. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-common Part5.
How was this patch tested?
Junit Test & mvn clean test
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?