-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-27944:HStore.needsCompaction() should return false if we disable comapction against a table #5303
Conversation
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Where do we call this method? Maybe at the caller place, we have already checked whether compaction is enabled at table level? |
Yes, we indeed check checked whether compaction is enabled, for example The code :
We will check whether compaction is enabled by calling
And this method would be called in these place. In here, I mean, since the main function of |
For me, I think different level has different checks, you do not need to do all the checks at every level. Here, if we always request compaction at region level from outside, it is not necessary to check whether we enable compaction at table level again, as we will check it at region level. |
Thanks for your comments, I understand |
Details see:HBASE-27944