HBASE-27950 ClientSideRegionScanner does not adhere to RegionScanner.nextRaw contract #5304

hgromer · 2023-06-22T15:58:39Z

Apache-HBase · 2023-06-22T16:36:41Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
-1 ❌	mvninstall	0m 55s	root in master failed.
-1 ❌	compile	0m 14s	hbase-server in master failed.
+1 💚	shadedjars	4m 56s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 7s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 14s	the patch passed
+1 💚	compile	0m 36s	the patch passed
+1 💚	javac	0m 36s	the patch passed
+1 💚	shadedjars	4m 53s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 23s	hbase-server generated 23 new + 0 unchanged - 0 fixed = 23 total (was 0)
		_ Other Tests _
-1 ❌	unit	9m 56s	hbase-server in the patch failed.
		26m 4s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5304/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5304
JIRA Issue	HBASE-26630
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 7e861f27a0b7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `da171c3`
Default Java	Temurin-1.8.0_352-b08
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5304/1/artifact/yetus-jdk8-hadoop3-check/output/branch-mvninstall-root.txt
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5304/1/artifact/yetus-jdk8-hadoop3-check/output/branch-compile-hbase-server.txt
javadoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5304/1/artifact/yetus-jdk8-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5304/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5304/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5304/1/testReport/
Max. process+thread count	1778 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5304/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-06-22T16:43:13Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 31s	master passed
+1 💚	compile	2m 35s	master passed
+1 💚	checkstyle	0m 34s	master passed
+1 💚	spotless	0m 41s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 24s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 29s	the patch passed
+1 💚	compile	2m 23s	the patch passed
+1 💚	javac	2m 23s	the patch passed
+1 💚	checkstyle	0m 30s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	9m 32s	Patch does not cause any errors with Hadoop 3.2.4 3.3.5.
+1 💚	spotless	0m 39s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 28s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		32m 18s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5304/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5304
JIRA Issue	HBASE-26630
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 52ddad65a9f4 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `da171c3`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5304/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-06-22T20:11:14Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 49s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 52s	master passed
+1 💚	compile	0m 46s	master passed
+1 💚	shadedjars	4m 38s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 28s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 42s	the patch passed
+1 💚	compile	0m 45s	the patch passed
+1 💚	javac	0m 45s	the patch passed
+1 💚	shadedjars	4m 34s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	the patch passed
		_ Other Tests _
-1 ❌	unit	218m 41s	hbase-server in the patch failed.
		240m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5304/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5304
JIRA Issue	HBASE-26630
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux a6a3cbab711c 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `da171c3`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5304/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5304/1/testReport/
Max. process+thread count	4659 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5304/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-06-23T02:21:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 33s	master passed
+1 💚	compile	2m 27s	master passed
+1 💚	checkstyle	0m 33s	master passed
+1 💚	spotless	0m 40s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 20s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 30s	the patch passed
+1 💚	compile	2m 26s	the patch passed
+1 💚	javac	2m 26s	the patch passed
+1 💚	checkstyle	0m 34s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	9m 24s	Patch does not cause any errors with Hadoop 3.2.4 3.3.5.
+1 💚	spotless	0m 39s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 31s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 8s	The patch does not generate ASF License warnings.
		30m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5304/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5304
JIRA Issue	HBASE-26630
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 5b84c82466fd 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `da171c3`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5304/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-06-23T05:49:25Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 10s	master passed
+1 💚	compile	0m 35s	master passed
+1 💚	shadedjars	4m 53s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 21s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 14s	the patch passed
+1 💚	compile	0m 36s	the patch passed
+1 💚	javac	0m 36s	the patch passed
+1 💚	shadedjars	4m 53s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	the patch passed
		_ Other Tests _
-1 ❌	unit	218m 50s	hbase-server in the patch failed.
		238m 54s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5304/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5304
JIRA Issue	HBASE-26630
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 8eb371fafdbb 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `da171c3`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5304/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5304/2/testReport/
Max. process+thread count	4507 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5304/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-06-23T05:50:48Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 51s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 33s	master passed
+1 💚	compile	0m 47s	master passed
+1 💚	shadedjars	4m 35s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 36s	the patch passed
+1 💚	compile	0m 47s	the patch passed
+1 💚	javac	0m 47s	the patch passed
+1 💚	shadedjars	4m 36s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	the patch passed
		_ Other Tests _
+1 💚	unit	218m 49s	hbase-server in the patch passed.
		240m 31s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5304/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5304
JIRA Issue	HBASE-26630
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 097381b00799 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `da171c3`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5304/2/testReport/
Max. process+thread count	4472 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5304/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

bbeaudreault · 2023-06-23T13:50:57Z

I updated this PR and the resulting merged commit message to link it to a new jira HBASE-27950. I realized that the old jira actually was not a problem, since the TableSnapshotInputFormat had been fixed to force ReadType.STREAM back in HBASE-26273, before HBASE-26630 was submitted. It was worth a new jira here so that we could still update ClientSideRegionScanner to honor the contract of RegionScanner.nextRaw for future proofing.

…nextRaw contract (#5304) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

Apache9 · 2023-06-23T15:43:59Z

I do not think force a stream read can fix the problem described in HBASE-26630?

The problem is that we should use the return value of nextRaw to determine whether there are still more values. This can not be fixed by changing the ReadType. And in HBASE-26273, we still allow users to change the ReadType back to PREAD, so it should not be considered as a 'fix' even if it can fix the problem right?

Opening a new issue is OK, but let's resolve HBASE-26630 as duplicated by HBASE-27950.

Thanks.

bbeaudreault · 2023-06-23T16:17:38Z

Yea, good point. Thanks, I'll fix the resolution.

…nextRaw contract (apache#5304) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

…nextRaw contract (#5304) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

… to RegionScanner.nextRaw contract (apache#5304) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

…nextRaw contract (apache#5304) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org> (cherry picked from commit d839fd4) Change-Id: I3d81cb0a667f4b572cbd4bac9265b4713e739f07

prevent early scan termination

4ed7d97

Apache9 approved these changes Jun 23, 2023

View reviewed changes

bbeaudreault approved these changes Jun 23, 2023

View reviewed changes

bbeaudreault changed the title ~~HBASE-26630: Prevent early FS scan termination~~ HBASE-27950 ClientSideRegionScanner does not adhere to RegionScanner.nextRaw contract Jun 23, 2023

bbeaudreault merged commit 66fd6db into apache:master Jun 23, 2023

hgromer deleted the HBASE-26630 branch June 23, 2023 13:55

bbeaudreault pushed a commit that referenced this pull request Jun 23, 2023

HBASE-27950 ClientSideRegionScanner does not adhere to RegionScanner.…

7d8e187

…nextRaw contract (#5304) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

bbeaudreault pushed a commit that referenced this pull request Jun 23, 2023

HBASE-27950 ClientSideRegionScanner does not adhere to RegionScanner.…

8b0dfc1

…nextRaw contract (#5304) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

bbeaudreault pushed a commit that referenced this pull request Jun 23, 2023

HBASE-27950 ClientSideRegionScanner does not adhere to RegionScanner.…

d839fd4

…nextRaw contract (#5304) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

bbeaudreault pushed a commit that referenced this pull request Jun 23, 2023

HBASE-27950 ClientSideRegionScanner does not adhere to RegionScanner.…

5d58928

…nextRaw contract (#5304) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-27950 ClientSideRegionScanner does not adhere to RegionScanner.nextRaw contract #5304

HBASE-27950 ClientSideRegionScanner does not adhere to RegionScanner.nextRaw contract #5304

hgromer commented Jun 22, 2023 •

edited by bbeaudreault

Loading

Apache-HBase commented Jun 22, 2023

Apache-HBase commented Jun 22, 2023

Apache-HBase commented Jun 22, 2023

Apache-HBase commented Jun 23, 2023

Apache-HBase commented Jun 23, 2023

Apache-HBase commented Jun 23, 2023

bbeaudreault commented Jun 23, 2023 •

edited

Loading

Apache9 commented Jun 23, 2023

bbeaudreault commented Jun 23, 2023

HBASE-27950 ClientSideRegionScanner does not adhere to RegionScanner.nextRaw contract #5304

HBASE-27950 ClientSideRegionScanner does not adhere to RegionScanner.nextRaw contract #5304

Conversation

hgromer commented Jun 22, 2023 • edited by bbeaudreault Loading

Apache-HBase commented Jun 22, 2023

Apache-HBase commented Jun 22, 2023

Apache-HBase commented Jun 22, 2023

Apache-HBase commented Jun 23, 2023

Apache-HBase commented Jun 23, 2023

Apache-HBase commented Jun 23, 2023

bbeaudreault commented Jun 23, 2023 • edited Loading

Apache9 commented Jun 23, 2023

bbeaudreault commented Jun 23, 2023

hgromer commented Jun 22, 2023 •

edited by bbeaudreault

Loading

bbeaudreault commented Jun 23, 2023 •

edited

Loading