HBASE-27968 add JvmPauseMonitor in hbase-client #5319
+69
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
wchevreuil
reviewed
Jul 10, 2023
| @@ -121,6 +122,8 @@ public class AsyncConnectionImpl implements AsyncConnection { | |||
| private final String metricsScope; | |||
| private final Optional<MetricsConnection> metrics; | |||
|
|
|||
| private JvmPauseMonitor pauseMonitor; | |||
There was a problem hiding this comment.
Make this a singleton, instead? In the case of applications opening or pooling multiple connections, we don't need a separate JvmPauseMonitor per connection, just a single one for the whole application.
There was a problem hiding this comment.
Good idea ! But if so, we may need to consider adding a reference count to pauseMonitor. Only when all connections that refer to it are no longer active, we can stop it . Or we can keep it all the time , even all the connections are closed ?
There was a problem hiding this comment.
Yeah, I think we don't need to stop it when connection is closed, it may be useful to have it running for as long the client application runs.
|
Thanks for the review @wchevreuil Sorry, I didn't find the |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Apache9
reviewed
Jul 13, 2023
| private JvmPauseMonitorSource metricsSource; | ||
| private final JvmPauseMonitorSource metricsSource; | ||
|
|
||
| public static synchronized JvmPauseMonitor getInstance(Configuration conf) { |
There was a problem hiding this comment.
Why change it to singleton? What if we pass different Configuration here?
There was a problem hiding this comment.
There are two reasons.
@wchevreuil mentioned that our user may open multiple connections, however only one pause monitor is enough for a process. More details please see here
There was a problem hiding this comment.
If we only want one JvmPauseMonitor in process, then we should not bind it to a connection? Just add a utility method to enable jvm pause monitor is enough?
There was a problem hiding this comment.
Ok. Let me try to fix this. Thanks Duo ! @Apache9
wchevreuil
approved these changes
Jul 13, 2023
Yeah, you are right. My bad, I was looking at older branches. LGTM, assuming the UT failures are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.