HBASE-29028 Backport missing UI patches to branch-2.5 #6542

PDavid · 2024-12-13T17:00:13Z

Cherry-picked the following patches which were missing on branch-2.5 branch. Most of these applied as a clean cherry-pick (without conflicts). Unfortunately there were some which had conflicts and I manually resolved them.
Each commit message contains from which commit it was cherry-picked from.

HBASE-27406 Make /prometheus endpoint accessible from HBase UI (HBASE-27406 Make "/prometheus" endpoint accessible from HBase UI #4833)
HBASE-27814 Add support for dump and process metrics servlet in REST InfoServer (HBASE-27814 Add support for dump and process metrics servlet in REST … #5215)
HBASE-18382 add transport type info into Thrift UI (HBASE-18382 add transport type info into Thrift UI #880)
HBASE-20693 Refactor thrift jsp's and extract header and footer (HBASE-20693 Refactor thrift jsp's and extract header and footer #5732)
HBASE-24624 Optimize table.jsp code (HBASE-24624 Optimize table.jsp code #1963) - ⚠️ This did not apply cleanly - had to resolve conflicts manually
HBASE-25402 Sorting order by start key or end key is not considering empty start key/end key (HBASE-25402 HBase UI: sorting order by start key or end key is not considering empty start key/end key #2955)
HBASE-27309 Add major compact table or region operation on master web table page (HBASE-27309 Add major compact table or region operation on master web… #4793)
HBASE-28778 NPE may occur when opening master-status or table.jsp or procedure.jsp while Master is initializing (HBASE-28778 NPE may occur when opening master-status or table.jsp or procedure.js… #6152)
HBASE-28305 Add "Uncompressed StoreFileSize" column to the table.jsp (HBASE-28305 Add "Uncompressed StoreFileSize" column to the table.jsp #5620)
HBASE-20452 Master UI: Table merge button should validate required fields before submit

Is it OK to have multiple patches in one PR like this or would you prefer having a separate PR for each commit?

…e#4833) Signed-off-by: Andor Molnar <andor@apache.org> Signed-off-by: Balazs Meszaros <meszibalu@apache.org> (cherry picked from commit dffc8e0)

…InfoServer (apache#5215) Other changes: - Ensure info server stops during stop() - Extract header and footer. This would fix the log level page layout for rest web UI (See HBASE-20693) - Add hostname in the landing page instead of just port similar to other web UIs Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> (cherry picked from commit a683fcf)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> Signed-off-by: Bharath Vissapragada <bharathv@apache.org> Signed-off-by: Viraj Jasani <virajjasani007@gmail.com> (cherry picked from commit 82e155e)

…he#5732) - Fixes the way logLevel page renders in UI Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> (cherry picked from commit ede4ccd)

Signed-off-by: Guangxu Cheng <gxcheng@apache.org> (cherry picked from commit 9ad16aa)

…empty start key/end key (apache#2955) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Pankaj Kumar<pankajkumar@apache.org> (cherry picked from commit 157200e)

… table page (apache#4793) Co-authored-by: zhengsicheng <zhengsicheng@jd.com> Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit eb6b274)

…procedure.jsp while Master is initializing (apache#6152) Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 3caaf2d)

…pache#5620) Co-authored-by: Haosen Chen <haosenchen@tencent.com> Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit e3a0174)

…elds before submit Signed-off-by: tedyu <yuzhihong@gmail.com> (cherry picked from commit 6ce1136)

Apache-HBase · 2024-12-16T16:33:24Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 53s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 21s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 25s		branch-2.5 passed
+1 💚	compile	4m 41s		branch-2.5 passed
+1 💚	checkstyle	1m 35s		branch-2.5 passed
+1 💚	spotbugs	3m 59s		branch-2.5 passed
+1 💚	spotless	1m 3s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 29s		the patch passed
+1 💚	compile	3m 50s		the patch passed
+1 💚	javac	3m 50s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 13s		the patch passed
+1 💚	spotbugs	3m 18s		the patch passed
+1 💚	hadoopcheck	20m 44s		Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6 3.4.0.
+1 💚	spotless	0m 47s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 28s		The patch does not generate ASF License warnings.
		52m 19s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6542/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6542
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux c6f0f6a29e3c 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `a9d154d`
Default Java	Eclipse Adoptium-11.0.23+9
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-server hbase-thrift hbase-rest U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6542/2/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-12-16T19:30:22Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 46s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 29s		branch-2.5 passed
+1 💚	compile	1m 16s		branch-2.5 passed
+1 💚	javadoc	0m 58s		branch-2.5 passed
+1 💚	shadedjars	5m 6s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 23s		the patch passed
+1 💚	compile	1m 20s		the patch passed
+1 💚	javac	1m 20s		the patch passed
+1 💚	javadoc	0m 59s		the patch passed
+1 💚	shadedjars	5m 6s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	169m 3s		hbase-server in the patch passed.
+1 💚	unit	6m 37s		hbase-thrift in the patch passed.
+1 💚	unit	4m 3s		hbase-rest in the patch passed.
		204m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6542/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#6542
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 058cd27969d8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `a9d154d`
Default Java	Temurin-1.8.0_412-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6542/2/testReport/
Max. process+thread count	3842 (vs. ulimit of 30000)
modules	C: hbase-server hbase-thrift hbase-rest U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6542/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-12-16T20:24:14Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 54s		Docker mode activated.
-0 ⚠️	yetus	0m 6s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 37s		branch-2.5 passed
+1 💚	compile	1m 43s		branch-2.5 passed
+1 💚	javadoc	1m 4s		branch-2.5 passed
+1 💚	shadedjars	5m 50s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 57s		the patch passed
+1 💚	compile	1m 33s		the patch passed
+1 💚	javac	1m 33s		the patch passed
+1 💚	javadoc	0m 56s		the patch passed
+1 💚	shadedjars	6m 5s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	191m 1s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
+1 💚	unit	7m 11s		hbase-thrift in the patch passed.
+1 💚	unit	3m 58s		hbase-rest in the patch passed.
		231m 58s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6542/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#6542
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux d0df9c2917f6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `a9d154d`
Default Java	Eclipse Adoptium-11.0.23+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6542/2/testReport/
Max. process+thread count	3897 (vs. ulimit of 30000)
modules	C: hbase-server hbase-thrift hbase-rest U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6542/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-12-16T20:27:19Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 28s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 19s		branch-2.5 passed
+1 💚	compile	2m 16s		branch-2.5 passed
+1 💚	javadoc	1m 16s		branch-2.5 passed
+1 💚	shadedjars	5m 40s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 23s		the patch passed
+1 💚	compile	2m 6s		the patch passed
+1 💚	javac	2m 6s		the patch passed
+1 💚	javadoc	1m 19s		the patch passed
+1 💚	shadedjars	5m 36s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	192m 39s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
+1 💚	unit	6m 55s		hbase-thrift in the patch passed.
+1 💚	unit	3m 51s		hbase-rest in the patch passed.
		233m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6542/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6542
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 5d6a079b5387 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `a9d154d`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6542/2/testReport/
Max. process+thread count	4167 (vs. ulimit of 30000)
modules	C: hbase-server hbase-thrift hbase-rest U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6542/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

NihalJain · 2024-12-19T06:00:34Z

Hi @PDavid please let me know once this PR is ready for review

PDavid · 2024-12-19T08:39:05Z

Hi @NihalJain,
Many thanks, I think this is now ready to review. Some tests failed in the PR build but I think they are not related.

NihalJain · 2024-12-24T07:19:43Z

Tried the change, they work fine for me:

Master: LGTM, except navbar all look good. Again navbar should not be issue as bootstrap bump will fix it eventually

Rest UI: LGTM

Thrift UI: LGTM

NihalJain

We may need to drop HBASE-27406 Make /prometheus endpoint accessible from HBase UI (#4833) as the feature is not even supported by backend.
Trying to open /prometheus give 404 with this change.

lucakovacs and others added 4 commits December 12, 2024 15:36

HBASE-27406 Make /prometheus endpoint accessible from HBase UI (apach…

137c6dc

…e#4833) Signed-off-by: Andor Molnar <andor@apache.org> Signed-off-by: Balazs Meszaros <meszibalu@apache.org> (cherry picked from commit dffc8e0)

HBASE-18382 add transport type info into Thrift UI (apache#880)

6a4dbea

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> Signed-off-by: Bharath Vissapragada <bharathv@apache.org> Signed-off-by: Viraj Jasani <virajjasani007@gmail.com> (cherry picked from commit 82e155e)

HBASE-20693 Refactor thrift jsp's and extract header and footer (apac…

71f65b5

…he#5732) - Fixes the way logLevel page renders in UI Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> (cherry picked from commit ede4ccd)

PDavid changed the title ~~HBASE-29028 Backport missing UI patches to branch-2.x~~ HBASE-29028 Backport missing UI patches to branch-2.5 Dec 13, 2024

This comment has been minimized.

Sign in to view

songxincun and others added 6 commits December 16, 2024 10:10

HBASE-24624 Optimize table.jsp code (apache#1963)

79a181e

Signed-off-by: Guangxu Cheng <gxcheng@apache.org> (cherry picked from commit 9ad16aa)

HBASE-25402 Sorting order by start key or end key is not considering …

b8d5f98

…empty start key/end key (apache#2955) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Pankaj Kumar<pankajkumar@apache.org> (cherry picked from commit 157200e)

HBASE-27309 Add major compact table or region operation on master web…

0b0ac60

… table page (apache#4793) Co-authored-by: zhengsicheng <zhengsicheng@jd.com> Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit eb6b274)

HBASE-28778 NPE may occur when opening master-status or table.jsp or …

8b14486

…procedure.jsp while Master is initializing (apache#6152) Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 3caaf2d)

HBASE-28305 Add "Uncompressed StoreFileSize" column to the table.jsp (a…

ebdeef2

…pache#5620) Co-authored-by: Haosen Chen <haosenchen@tencent.com> Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit e3a0174)

HBASE-20452 Master UI: Table merge button should validate required fi…

a9d154d

…elds before submit Signed-off-by: tedyu <yuzhihong@gmail.com> (cherry picked from commit 6ce1136)

PDavid force-pushed the HBASE-29028-UI-missing-patches-branch-2.5 branch from ed87ac8 to a9d154d Compare December 16, 2024 09:19

PDavid mentioned this pull request Dec 16, 2024

HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 #6490

Merged

PDavid marked this pull request as ready for review December 18, 2024 07:23

NihalJain requested changes Dec 24, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-29028 Backport missing UI patches to branch-2.5 #6542

HBASE-29028 Backport missing UI patches to branch-2.5 #6542

PDavid commented Dec 13, 2024 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Dec 16, 2024

Apache-HBase commented Dec 16, 2024

Apache-HBase commented Dec 16, 2024

Apache-HBase commented Dec 16, 2024

NihalJain commented Dec 19, 2024

PDavid commented Dec 19, 2024

NihalJain commented Dec 24, 2024 •

edited

Loading

NihalJain left a comment •

edited

Loading

HBASE-29028 Backport missing UI patches to branch-2.5 #6542

Are you sure you want to change the base?

HBASE-29028 Backport missing UI patches to branch-2.5 #6542

Conversation

PDavid commented Dec 13, 2024 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Dec 16, 2024

Apache-HBase commented Dec 16, 2024

Apache-HBase commented Dec 16, 2024

Apache-HBase commented Dec 16, 2024

NihalJain commented Dec 19, 2024

PDavid commented Dec 19, 2024

NihalJain commented Dec 24, 2024 • edited Loading

NihalJain left a comment • edited Loading

Choose a reason for hiding this comment

PDavid commented Dec 13, 2024 •

edited

Loading

NihalJain commented Dec 24, 2024 •

edited

Loading

NihalJain left a comment •

edited

Loading