Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-29036 Backport missing UI patches to branch-2.6 #6546

Closed
wants to merge 5 commits into from
Closed

HBASE-29036 Backport missing UI patches to branch-2.6 #6546

wants to merge 5 commits into from

Conversation

PDavid
Copy link
Contributor

@PDavid PDavid commented Dec 16, 2024

Cherry-picked the following patches which were missing on branch-2.6 branch. Most of these applied as a clean cherry-pick (without conflicts). Unfortunately there were some which had conflicts and I manually resolved them.
Each commit message contains from which commit it was cherry-picked from.

Is it OK to have multiple patches in one PR like this or would you prefer having a separate PR for each commit?

bea0113 and others added 5 commits December 13, 2024 18:26
@bea0113 @PDavid
HBASE-18382 add transport type info into Thrift UI (apache#880)
b349c30 
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
Signed-off-by: Viraj Jasani <virajjasani007@gmail.com>
(cherry picked from commit 82e155e)
@NihalJain @PDavid
HBASE-20693 Refactor thrift jsp's and extract header and footer (apac…
893031f 
…he#5732)

- Fixes the way logLevel page renders in UI

Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit ede4ccd)
@songxincun @PDavid
HBASE-24624 Optimize table.jsp code (apache#1963)
e1fad5c 
Signed-off-by: Guangxu Cheng <gxcheng@apache.org>
(cherry picked from commit 9ad16aa)
@AkshayTSudheer @PDavid
HBASE-25402 Sorting order by start key or end key is not considering …
3a3729f 
…empty start key/end key (apache#2955)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Pankaj Kumar<pankajkumar@apache.org>
(cherry picked from commit 157200e)
@guluo2016 @PDavid
HBASE-28778 NPE may occur when opening master-status or table.jsp or …
2f0dc4e 
…procedure.jsp while Master is initializing (apache#6152)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 3caaf2d)
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 48s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2.6 Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for branch
+1 💚 mvninstall 3m 16s branch-2.6 passed
+1 💚 spotless 1m 0s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 3m 31s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 spotless 1m 2s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 24s The patch does not generate ASF License warnings.
11m 54s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6546/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6546
Optional Tests dupname asflicense javac codespell detsecrets spotless
uname Linux 6f5e186a329c 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.6 / 2f0dc4e
Default Java Eclipse Adoptium-11.0.23+9
Max. process+thread count 79 (vs. ulimit of 30000)
modules C: hbase-server hbase-thrift U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6546/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 49s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 2m 32s branch-2.6 passed
+1 💚 javadoc 0m 43s branch-2.6 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 2m 18s the patch passed
+1 💚 javadoc 0m 42s the patch passed
_ Other Tests _
+1 💚 unit 180m 41s hbase-server in the patch passed.
+1 💚 unit 6m 58s hbase-thrift in the patch passed.
199m 48s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6546/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #6546
Optional Tests javac javadoc unit
uname Linux 84ddae74fcfa 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.6 / 2f0dc4e
Default Java Temurin-1.8.0_412-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6546/1/testReport/
Max. process+thread count 4181 (vs. ulimit of 30000)
modules C: hbase-server hbase-thrift U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6546/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 50s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+0 🆗 mvndep 0m 6s Maven dependency ordering for branch
+1 💚 mvninstall 2m 40s branch-2.6 passed
+1 💚 javadoc 0m 44s branch-2.6 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 2m 36s the patch passed
+1 💚 javadoc 0m 44s the patch passed
_ Other Tests _
+1 💚 unit 179m 50s hbase-server in the patch passed.
+1 💚 unit 7m 19s hbase-thrift in the patch passed.
199m 23s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6546/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6546
Optional Tests javac javadoc unit
uname Linux d893c2739ea5 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.6 / 2f0dc4e
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6546/1/testReport/
Max. process+thread count 4163 (vs. ulimit of 30000)
modules C: hbase-server hbase-thrift U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6546/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 59s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 3m 55s branch-2.6 passed
+1 💚 javadoc 1m 3s branch-2.6 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for patch
+1 💚 mvninstall 3m 49s the patch passed
+1 💚 javadoc 0m 45s the patch passed
_ Other Tests _
+1 💚 unit 217m 26s hbase-server in the patch passed.
+1 💚 unit 7m 28s hbase-thrift in the patch passed.
240m 49s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6546/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #6546
Optional Tests javac javadoc unit
uname Linux 9fa1a2b389a1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.6 / 2f0dc4e
Default Java Eclipse Adoptium-11.0.23+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6546/1/testReport/
Max. process+thread count 4077 (vs. ulimit of 30000)
modules C: hbase-server hbase-thrift U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6546/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@PDavid PDavid marked this pull request as ready for review December 16, 2024 12:09
@PDavid PDavid mentioned this pull request Dec 16, 2024
Merged
@PDavid PDavid changed the title HBASE-29028 Backport missing UI patches to branch-2.6 HBASE-29036 Backport missing UI patches to branch-2.6 Dec 18, 2024
@PDavid
Copy link
Contributor Author

PDavid commented Dec 18, 2024

Closing this in favor of #6550 (different Jira ticket ID)

@PDavid PDavid closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@PDavid @Apache-HBase @bea0113 @NihalJain @songxincun @AkshayTSudheer @guluo2016