HBASE-29040 Fix description of "sampleRate" of PerformanceEvaluation #6558
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junegunn
commented
Dec 23, 2024
| @@ -1205,7 +1205,7 @@ private static long nextRandomSeed() { | |||
| this.opts = options; | |||
| this.status = status; | |||
| this.testName = this.getClass().getSimpleName(); | |||
| everyN = (int) (opts.totalRows / (opts.totalRows * opts.sampleRate)); | |||
| everyN = (int) (1 / opts.sampleRate); | |||
There was a problem hiding this comment.
This is unrelated to the problem described, but I thought why not.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
reviewed
Dec 29, 2024
| @@ -1205,7 +1205,7 @@ private static long nextRandomSeed() { | |||
| this.opts = options; | |||
| this.status = status; | |||
| this.testName = this.getClass().getSimpleName(); | |||
| everyN = (long) (opts.totalRows / (opts.totalRows * opts.sampleRate)); | |||
| everyN = (long) (1 / opts.sampleRate); | |||
There was a problem hiding this comment.
I'm not sure whether (long) (1 / 1.0) will give us the correct result? Could it be 0?
There was a problem hiding this comment.
AFAIK, we don't have to worry about it because 1.0 (1 / 20) has a finite binary representation (unlike numbers like 0.1 or 0.2), so (1 / 1.0) will not yield any arithmetic error.
irb(main):001> [0].pack('G').bytes.map { "%08b" % it }.join
=> "0000000000000000000000000000000000000000000000000000000000000000"
irb(main):002> [1].pack('G').bytes.map { "%08b" % it }.join
=> "0011111111110000000000000000000000000000000000000000000000000000"
irb(main):003> [0.1].pack('G').bytes.map { "%08b" % it }.join
=> "0011111110111001100110011001100110011001100110011001100110011010"
irb(main):004> [0.2].pack('G').bytes.map { "%08b" % it }.join
=> "0011111111001001100110011001100110011001100110011001100110011010"
https://en.wikipedia.org/wiki/Double-precision_floating-point_format#Double-precision_examples
Apache9
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option applies to all tests since HBASE-10788.