HBASE-29013 Make PerformanceEvaluation support larger data sets (branch-2) #6559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use 8-byte long integers in the code to prevent integer overflows. Signed-off-by: Duo Zhang <zhangduo@apache.org> Reviewed-by: Peng Lu <lupeng_nwpu@qq.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Apache9
reviewed
Dec 24, 2024
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
Show resolved
Hide resolved
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
Show resolved
Hide resolved
Apache9
reviewed
Dec 26, 2024
| @@ -1149,7 +1149,7 @@ private static long nextRandomSeed() { | |||
| return randomSeed.nextLong(); | |||
| } | |||
|
|
|||
| private final int everyN; | |||
| private final long everyN; | |||
|
|
|||
| protected final Random rand = new Random(nextRandomSeed()); | |||
There was a problem hiding this comment.
So we can remove this now?
There was a problem hiding this comment.
Yes, we can. I didn't remove it in the first place because I wanted to minimize the code change, but now that we agree on using ThreadLocalRandom, let me clean this up.
There was a problem hiding this comment.
On the second thought, we can keep this member and just set it to ThreadLocalRandom.current() to minimize the required code change. TestBase instances are created on the fly by each thread in the pool (TestClient-%s), so I think it's safe to do it this way. What do you think?
diff --git a/hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java b/hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
index ffe33a9e8b..7bbccbd48d 100644
--- a/hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
+++ b/hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
@@ -1141,17 +1141,9 @@ public class PerformanceEvaluation extends Configured implements Tool {
* A test. Subclass to particularize what happens per row.
*/
static abstract class TestBase {
- // Below is make it so when Tests are all running in the one
- // jvm, that they each have a differently seeded Random.
- private static final Random randomSeed = new Random(EnvironmentEdgeManager.currentTime());
-
- private static long nextRandomSeed() {
- return randomSeed.nextLong();
- }
-
private final long everyN;
- protected final Random rand = new Random(nextRandomSeed());
+ protected final Random rand = ThreadLocalRandom.current();
protected final Configuration conf;
protected final TestOptions opts;
There was a problem hiding this comment.
to minimize the required code change
generateData is used in other places, but without a custom seed value.
So it's actually trivial to remove the Random parameter altogether.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
approved these changes
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked 6ebd48e and replaced
Random#nextLong(bound)which is not available on JDK 8 withThreadLocalRandom#nextLong(bound)(e140ae7).Not being able to provide a seed doesn't matter in this context, so this should be good enough.