bugfix mongodb collect extra metrics npe (#1257)

apache · Sep 23, 2023 · 8aba410 · 8aba410
1 parent 52ba298
commit 8aba410
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/...c/main/java/org/dromara/hertzbeat/collector/collect/mongodb/MongodbSingleCollectImpl.java b/...c/main/java/org/dromara/hertzbeat/collector/collect/mongodb/MongodbSingleCollectImpl.java
@@ -112,6 +112,9 @@ public void collect(CollectRep.MetricsData.Builder builder, long appId, String a
                     document = (Document) document.get(metricsParts[i]);
                 }
             }
+            if (document == null) {
+                throw new RuntimeException("the document get from command " + metrics.getMongodb().getCommand()  + " is null.");
+            }
             fillBuilder(metrics, valueRowBuilder, document);
             builder.addValues(valueRowBuilder.build());
         } catch (MongoServerUnavailableException | MongoTimeoutException unavailableException) {
@@ -137,7 +140,7 @@ public String supportProtocol() {
     private void fillBuilder(Metrics metrics, CollectRep.ValueRow.Builder valueRowBuilder, Document document) {
         metrics.getAliasFields().forEach(it -> {
             if (document.containsKey(it)) {
-                Object fieldValue =document.get(it);
+                Object fieldValue = document.get(it);
                 if (fieldValue == null) {
                     valueRowBuilder.addColumns(CommonConstants.NULL_VALUE);
                 } else {